Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change list command output from tabulate to rich tables #359

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Haris-Ali007
Copy link

Issue resolved: I have updated the list bash output by replacing the tabulate table with rich tables.

File updated: cli/_print_utils.py

The output looks like this:
image

@CLA-Mercedes-Benz
Copy link

CLA-Mercedes-Benz commented Nov 3, 2024

CLA assistant check
All committers have signed the CLA.

odxtools/cli/_print_utils.py Show resolved Hide resolved
odxtools/cli/_print_utils.py Show resolved Hide resolved
Copy link
Collaborator

@andlaus andlaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except for the fact that the CI system complains about this, this looks good to me. (replacing the tabulate module for browse and compare would be nice, too...)

@andlaus
Copy link
Collaborator

andlaus commented Nov 12, 2024

@Haris-Ali007: what's the status here? before I can merge this, at least the CI complaints must be fixed...

@Haris-Ali007
Copy link
Author

@Haris-Ali007: what's the status here? before I can merge this, at least the CI complaints must be fixed...

Yes apologies for the delay. I am fixing the issues.

odxtools/cli/browse.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@kayoub5 kayoub5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants